Scheduler - Migrate popup customization tests to isolated environment#33802
Merged
bit-byte0 merged 3 commits intoJun 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates Scheduler appointment popup/form customization tests from full dxScheduler integration coverage to the isolated AppointmentPopup test harness, reducing test runtime and dependency on the full Scheduler environment.
Changes:
- Added isolated tests verifying
editing.popupcustomization is applied/merged correctly (including callbacks, toolbar items, deferRendering, and width/maxWidth behavior). - Added isolated tests verifying
editing.formcustomization is applied/merged correctly (includingelementAttr.classpreservation). - Removed the equivalent customization tests from the full Scheduler integration test suite to avoid duplication.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts | Adds isolated-environment coverage for popup (editing.popup) and form (editing.form) customization behavior. |
| packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.integration.test.ts | Removes customization tests that were migrated to the isolated AppointmentPopup suite. |
Tucchhaa
previously approved these changes
Jun 3, 2026
aleksei-semikozov
previously approved these changes
Jun 5, 2026
…ests Signed-off-by: Maksim Zakharov <251575087+bit-byte0@users.noreply.github.com>
bit-byte0
dismissed stale reviews from aleksei-semikozov and Tucchhaa
via
e628ddc
Tucchhaa
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrated 15 popup/form customization tests from full Scheduler to isolated env.
How
Replaced
createScheduler()andshowAppointmentPopup()withcreateAppointmentPopup()directly